fix(material-experimental/mdc-tooltip): fix text alignment of multili… #22981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne tooltips * Add the 'mdc-tooltip--multiline' class when a tooltip overflows to make the text align left (or right in rtl) instead of center
google-cla
bot
added
the
cla: yes
crisbeto
reviewed
Jun 16, 2021
Member
crisbeto
left a comment
crisbeto
left a comment
There was a problem hiding this comment.
Should we have a test for the new code?
Contributor
Author
Yes, it definitely should. I'll add one today 👍🏽 |
…multiline tooltips
…multiline tooltips
…multiline tooltips
wagnermaciel
added
action: merge
…s set on tooltips with messages that overflow
…multiline tooltips
…multiline tooltips
mmalerba
pushed a commit
that referenced
this pull request
Jun 18, 2021
#22981) * fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips * Add the 'mdc-tooltip--multiline' class when a tooltip overflows to make the text align left (or right in rtl) instead of center * fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips * fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips * fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips * test(material-experimental/mdc-tooltip): ensure the multiline class is set on tooltips with messages that overflow * fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips * fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips (cherry picked from commit 81cd26b)
mmalerba
pushed a commit
that referenced
this pull request
Jun 18, 2021
#22981) * fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips * Add the 'mdc-tooltip--multiline' class when a tooltip overflows to make the text align left (or right in rtl) instead of center * fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips * fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips * fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips * test(material-experimental/mdc-tooltip): ensure the multiline class is set on tooltips with messages that overflow * fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips * fixup! fix(material-experimental/mdc-tooltip): fix text alignment of multiline tooltips (cherry picked from commit 81cd26b)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ne tooltips
to make the text align left (or right in rtl) instead of center